Skip to content

Conversation

@MichaelChirico
Copy link
Contributor

@MichaelChirico MichaelChirico commented Oct 10, 2023

We could also add these indirectly-included headers:

  • <stdio.h> for snprintf
  • <string.h> for strspn, strlen, strcat

These three (<math.h>, <stdio.h>, <string.h>) could replace <stdlib.h>.

We could also add specific headers for R:

  • <R_ext/Arith.h> for NA_LOGICAL, NA_INTEGER, ISNA, ISNAN, R_FINITE, R_PosInf, R_NegInf
  • <R_ext/Error.h> for error

Feel free to request any of these changes, or to just close if transitive inclusion via <stdlib.h> is fine with you.

@MichaelChirico MichaelChirico changed the title #include <math.h> for ceil, fmin, fmax, log10 #include <math.h> for ceil, fmin, fmax, fabs, log10 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant