Skip to content

Add a backward compatible way of getting random bytes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a backward compatible way of getting random bytes #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/websocket_client.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ error_info(Handler, Reason, State) ->
-spec generate_ws_key() ->
binary().
generate_ws_key() ->
base64:encode(crypto:strong_rand_bytes(16)).
base64:encode(rand_bytes(16)).

%% @doc Validate handshake response challenge
-spec validate_handshake(HandshakeResponse :: binary(), Key :: binary()) -> {ok, binary()} | {error, term()}.
Expand Down Expand Up @@ -430,7 +430,7 @@ encode_frame({Type, Payload}) ->
Opcode = websocket_req:name_to_opcode(Type),
Len = iolist_size(Payload),
BinLen = payload_length_to_binary(Len),
MaskingKeyBin = crypto:strong_rand_bytes(4),
MaskingKeyBin = rand_bytes(4),
<< MaskingKey:32 >> = MaskingKeyBin,
Header = << 1:1, 0:3, Opcode:4, 1:1, BinLen/bits, MaskingKeyBin/bits >>,
MaskedPayload = mask_payload(MaskingKey, Payload),
Expand Down Expand Up @@ -482,3 +482,12 @@ set_continuation_if_empty(WSReq, Opcode) ->
_ ->
WSReq
end.

rand_bytes(N) ->
case has_crypto_strong_rand_bytes() of
true -> crypto:strong_rand_bytes(N);
false -> (fun crypto:rand_bytes/1)(N)
end.

has_crypto_strong_rand_bytes() ->
erlang:function_exported(crypto, strong_rand_bytes, 1).