Skip to content

Use explicit group ID #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
car-roll merged 1 commit into from
May 5, 2022
Merged

Use explicit group ID #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
</dependencyManagement>
<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
Copy link

@car-roll car-roll May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark a comment or TODO here? Otherwise I feel like this will get reverted by some well-meaning individual and some maintainer (including myself) will not realize and let it through.

Copy link
Member Author

@basil basil May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what kind of comment you want to see. Referring to group IDs by their literal form rather than an interpolated string is the norm, not the exception. Moreover, I don't see what action there is to take, so I'm not sure what kind of TODO to write.

Copy link

@car-roll car-roll May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to group IDs by their literal form rather than an interpolated string is the norm, not the exception

That was my confusion. I thought it was the other way around, so I thought someone in the future might accidentally clean up the pom and give you trouble down the road. If that's the case, then no action needed.

<artifactId>workflow-step-api</artifactId>
</dependency>
<dependency>
Expand Down