Skip to content

Fix resume issues [JENKINS-49686] and [JENKINS-50199] and [JENKINS-50407] #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svanoort merged 17 commits into from
Apr 8, 2018
Merged

Fix resume issues [JENKINS-49686] and [JENKINS-50199] and [JENKINS-50407] #93

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b749460
Make completed persistent and use a guard object for synchronization …
svanoort Mar 22, 2018
960c5cc
Remove redundant save operations from graphListener if durability set…
svanoort Mar 22, 2018
4107ee4
Set completed sooner when finishing run, limit scope of locking and s…
svanoort Mar 26, 2018
ab4455d
Ensure some key execution state transitions happen even if errors occ…
svanoort Mar 26, 2018
472e5f0
Safely lazy-load the execution state
svanoort Mar 26, 2018
841eaea
More hardening of FlowExecution lazyLoad
svanoort Mar 26, 2018
1d7e873
Simplify conditionals
svanoort Mar 27, 2018
b3d13b4
Test cases for lazy-load FlowExecution
svanoort Mar 27, 2018
2039dc0
Prevent NPEs around listener use by switching to an intializing getter
svanoort Mar 29, 2018
3cc104b
Typo
svanoort Mar 30, 2018
bb334e1
A few review changes
svanoort Apr 3, 2018
75d05c5
Additional hardening based on workflow-cps FlowDurabilityTest fuzzing
svanoort Apr 3, 2018
a535449
Fix another bug that can cause completed to be unset and not persisted
svanoort Apr 4, 2018
d2e5b3c
Implement the review changes suggested by @jglick on top of the last …
svanoort Apr 4, 2018
eb258f8
Clarify some of listener use and synchronization
svanoort Apr 6, 2018
3e12266
More explanatory comment
svanoort Apr 6, 2018
db23202
Merge branch 'master' into fix-resume-issues
svanoort Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
<workflow-support-plugin.version>2.17</workflow-support-plugin.version>
<scm-api-plugin.version>2.1.1</scm-api-plugin.version>
<git-plugin.version>3.2.0</git-plugin.version>
<jenkins-test-harness.version>2.33</jenkins-test-harness.version>
Copy link
Member

@jglick jglick Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update parent POM to 3.4 or newer.

</properties>
<dependencies>
<dependency>
Expand Down
Loading