DefaultLogStorageTest.performance
#528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Apr 25, 2025
|
|
||
| @WithTimeout(600) | ||
| @Issue("JENKINS-75081") | ||
| @Test public void giantLogRunning() throws Exception { |
Member
Author
There was a problem hiding this comment.
Before: passes in 132s.
After: passes in 135s.
Code path not changed here, either way uses an inefficient system but at least only in smallish chunks.
jglick
commented
Apr 25, 2025
|
|
||
| @WithTimeout(600) | ||
| @Issue("JENKINS-75081") | ||
| @Test public void giantLogCompleted() throws Exception { |
Member
Author
There was a problem hiding this comment.
Before: crashes with multiple OOMEs.
After: OOMEs in WebClient, so I guess I need to rewrite the test.
Member
Author
There was a problem hiding this comment.
Also after:
java.lang.OutOfMemoryError: Java heap space
at org.kohsuke.stapler.framework.io.CharSpool.renew(CharSpool.java:63)
at org.kohsuke.stapler.framework.io.CharSpool.write(CharSpool.java:50)
at java.base/java.io.Writer.implWrite(Writer.java:334)
at java.base/java.io.Writer.write(Writer.java:318)
at java.base/java.io.Writer.write(Writer.java:278)
at hudson.console.ConsoleAnnotationOutputStream.eol(ConsoleAnnotationOutputStream.java:148)
at hudson.console.LineTransformationOutputStream.eol(LineTransformationOutputStream.java:69)
at hudson.console.LineTransformationOutputStream.write(LineTransformationOutputStream.java:62)
at java.base/java.io.FilterOutputStream.write(FilterOutputStream.java:89)
at org.jenkinsci.plugins.workflow.log.FileLogStorage$1$1.write(FileLogStorage.java:252)
at java.base/java.io.FilterOutputStream.write(FilterOutputStream.java:139)
at org.apache.commons.io.output.ProxyOutputStream.write(ProxyOutputStream.java:213)
at org.kohsuke.stapler.framework.io.LargeText.writeLogUncounted(LargeText.java:250)
at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:235)
at hudson.console.AnnotatedLargeText.writeRawLogTo(AnnotatedLargeText.java:234)
at org.jenkinsci.plugins.workflow.log.FileLogStorage$1.writeHtmlTo(FileLogStorage.java:217)
at hudson.console.AnnotatedLargeText.writeLogTo(AnnotatedLargeText.java:208)
at org.kohsuke.stapler.framework.io.LargeText.doProgressTextImpl(LargeText.java:319)
at org.kohsuke.stapler.framework.io.LargeText.doProgressText(LargeText.java:277)
at hudson.console.AnnotatedLargeText.doProgressiveHtmlImpl(AnnotatedLargeText.java:119)
at hudson.console.AnnotatedLargeText.doProgressiveHtml(AnnotatedLargeText.java:104)
which as noted cannot be solved (we cannot avoid buffering in HTML mode).
Member
Author
There was a problem hiding this comment.
Before, with new HTTP client, and after ceasing to even bother to test progressiveHtml on a completed build:
console fails
java.lang.OutOfMemoryError: Java heap space
at java.base/java.util.Arrays.copyOf(Arrays.java:3541)
at java.base/java.io.ByteArrayOutputStream.ensureCapacity(ByteArrayOutputStream.java:100)
at java.base/java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:132)
at org.apache.commons.io.output.ProxyOutputStream.write(ProxyOutputStream.java:147)
at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:244)
at hudson.console.AnnotatedLargeText.writeRawLogTo(AnnotatedLargeText.java:226)
at org.jenkinsci.plugins.workflow.job.WorkflowRun$$Lambda/0x000000010099e798.writeLogTo(Unknown Source)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.writeLogTo(WorkflowRun.java:1167)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.getLogInputStream(WorkflowRun.java:1135)
at hudson.model.Run.writeLogTo(Run.java:1464)
consoleFull passes (oddly)
consoleText passes
progressiveText fails
java.lang.OutOfMemoryError: Java heap space
at org.kohsuke.stapler.framework.io.CharSpool.renew(CharSpool.java:63)
at org.kohsuke.stapler.framework.io.CharSpool.write(CharSpool.java:50)
at org.kohsuke.stapler.framework.io.WriterOutputStream.flushOutput(WriterOutputStream.java:90)
at org.kohsuke.stapler.framework.io.WriterOutputStream.decode(WriterOutputStream.java:125)
at org.kohsuke.stapler.framework.io.WriterOutputStream.write(WriterOutputStream.java:73)
at hudson.console.PlainTextConsoleOutputStream.eol(PlainTextConsoleOutputStream.java:86)
at hudson.console.LineTransformationOutputStream.eol(LineTransformationOutputStream.java:69)
at hudson.console.LineTransformationOutputStream.write(LineTransformationOutputStream.java:62)
at hudson.console.LineTransformationOutputStream.write(LineTransformationOutputStream.java:84)
at org.apache.commons.io.output.ProxyOutputStream.write(ProxyOutputStream.java:147)
at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:244)
at hudson.console.AnnotatedLargeText.writeLogTo(AnnotatedLargeText.java:217)
at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:218)
at hudson.console.AnnotatedLargeText.writeLogTo(AnnotatedLargeText.java:207)
at org.kohsuke.stapler.framework.io.LargeText.doProgressTextImpl(LargeText.java:311)
at org.kohsuke.stapler.framework.io.LargeText.doProgressText(LargeText.java:274)
at hudson.console.AnnotatedLargeText.doProgressiveText(AnnotatedLargeText.java:128)
After:
all pass.
…d`; it is sure to crash, but `console.jelly` does not use it anyway
This was referenced Apr 25, 2025
dwnusbaum
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged whenever; just provides a harness to evaluate jenkinsci/stapler#657 + jenkinsci/jenkins#10515.