Switch WorkflowRunRestartTest to JenkinsSessionRule
#356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
May 23, 2023
|
|
||
| @Issue({"JENKINS-45585", "JENKINS-50784"}) // Verifies execution lazy-load | ||
| @Test public void lazyLoadExecution() { | ||
| story.thenWithHardShutdown(r -> { |
Member
Author
There was a problem hiding this comment.
This method does not exist in JenkinsSessionRule. Rarely needed; no apparent reason for it to have been added in #93.
Member
Author
Member
Author
There was a problem hiding this comment.
Ah, have it. thenWithHardShutdown blocks FlowExecutionList.saveAll, and unregister saves asynchronously, so after a restart an attempt is made to load this supposedly running build and WorkflowRun.getExecution is called, which can cause the test to fail. Switching to then fixes this, as does simply sleeping momentarily.
car-roll
approved these changes
May 24, 2023
…ugin into WorkflowRunRestartTest
dwnusbaum
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.