Remove some no-op overrides #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
approved these changes
Jan 23, 2019
Member
There was a problem hiding this comment.
Thanks for the PR!
jenkinsci/jenkins#3099 shipped in 2.100 (non-LTS) and 2.107 (LTS), as reported by git tag --contains 5e6b1050b2
The output of git tag --contains appears to be ASCII-sorted, so 2.100 is sorted to the top, but the commit went into 2.86 and the 2.89.x LTS even earlier (cf. jenkinsci/jenkins@5e6b105).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was perusing the source tree while debugging an unrelated issue and came across these TODOs. The TODOs were added in #79, which removed some unnecessary overrides noticed as part of jenkinsci/jenkins#3099 but left these since
workflow-job's baseline at the time (2.72) did not yet have jenkinsci/jenkins#3099. jenkinsci/jenkins#3099 shipped in 2.100 (non-LTS) and 2.107 (LTS), as reported bygit tag --contains 5e6b1050b2.workflow-job's baseline is now Jenkins 2.121.1, which does contain jenkinsci/jenkins#3099. So now we can complete these TODOs.To test this change, I ran
mvn clean packagelocally. It passed. Please let me know if there is any additional testing I should do.