Skip to content

[WIP] Log handling rewrite modifications #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
svanoort wants to merge 77 commits into from
Closed

[WIP] Log handling rewrite modifications #108

svanoort wants to merge 77 commits into from

Conversation

@svanoort
Copy link
Member

@svanoort svanoort commented Oct 4, 2018 •
edited
Loading

Builds on top of #27 -- do not merge yet (there's a direct PR to that branch open)

jglick added 30 commits September 23, 2016 18:46
@jglick
[JENKINS-38381] Prototype of log handling rewrite.
c229421
@jglick
Pick up jenkinsci/maven-hpi-plugin#25.
754ab9e
@jglick
Updated dependency versions.
e3ccb7b
@jglick
Obsolete Javadoc comment.
721bc75
@jglick
Reproduced AssociatedNodeNote error in a test.
30d64c7
@jglick
Another snapshot version forgotten.
78c5fbf
@jglick
Lighter-weight way of marking which node printed a line.
875b3ed
@jglick
FindBugs
f2f1296
@jglick
Updated TODOs.
141d748
@jglick
Extracting createBuildListener.
19530bd
@jglick
2.16 parent
4579f77
@jglick
Prototype SPI for replacing the log file of a build.
6f1ab49
@jglick
Deleting comment implemented as jenkinsci/jenkins-test-harness#38.
e57d7c6
@jglick
Faulty _getLogInputStream caused StackOverflowError’s in the normal c…
7db5d9d 
…ase.
@jglick
Pending jenkinsci/jenkins-test-harness#38 avoid printing a stack trac…
e4968ef 
…e for getLogFile().
@jglick
Reimplemented HTML display of Pipeline console to include some featur…
e6a58e8 
…es from jenkinsci#21.
@jglick
FindBugs
f46b98c
@jglick
Hide the show/hide link except during hover.
62ccf49
@jglick
Do not hide a “show” link.
51fdc25
@jglick
[JENKINS-27394] Better implementation of collapsible sections, finall…
d34d03e 
…y encompassing all of the functionality of jenkinsci#21.
@jglick
Discovered a problem with NewNodeConsoleNote and LabelAction.
aa12940
@jglick
Found a fix for the LabelAction timing problem.
08268a3
@jglick
Fixed a bug in enclosing logic.
d2a39dd
@jglick
Noting LessAbstractTaskListener.
89559d5
@jglick
Merge branch 'master' into logs-JENKINS-38381
211bd14 
Also using jitpack and linking to jenkinsci/maven-hpi-plugin#46 & jenkinsci/workflow-api-plugin#17 & jenkinsci/workflow-support-plugin#15.
@jglick
hpi-plugin.version=1.121
72d29d0
@jglick
getLog should take a long start argument.
2de9add
@jglick
Need jenkinsci/maven-hpi-plugin#48 to get hpi:run to work.
b0c6369 
Unfortunately it is also necessary to <exclude> the official dependency GAs to avoid duplication,
which seems like a fundamental limitation of jitpack.io as applied to Maven.
@jglick
Giving up on jitpack for now.
0f511fa
@jglick
Added a crude scalability test.
c88e980
jglick and others added 21 commits August 6, 2018 14:57
@jglick
Merge branch 'UTF-8-JENKINS-31096' into logs-JENKINS-38381
4c76b65
@jglick
Merge branch 'master' into logs-JENKINS-38381
49c91cd
@jglick
Adapted to FileLogStorage.
096aeab
@jglick
Replacing deprecated FlowScanningUtils.fetchEnclosingBlocks with Flow…
d450172 
…Node.iterateEnclosingBlocks.
@jglick
Found a couple of places where WorkflowRun.listener was being imprope…
8873326 
…rly accessed directly.
@jglick
Updated comments.
acd07c0
@jglick
Nulling out listener after close, and expanding upon an earlier comme…
3474475 
…nt which I think would need a patch to workflow-cps to handle properly.
@jglick
Logging a condition which is probably impossible.
17a0d2a
@jglick
Showing that it is quick (0ms for me) to display short node log text …
0a39b1c 
…even when the overall build is long.
@jglick
Merge branch 'master' into logs-JENKINS-38381
6eac61d
@jglick
Apparently flaky tests.
6f5d227
@jglick
Obsolete comment.
2aa0348
@jglick
Demonstrating that a JEP-210 upgrade preserves both whole-build and s…
ae21cee 
…tep logs, even for steps running across the upgrade.

In this example, log is complete and the raw log is identical to what it would have been without an upgrade;
the first echo step and the sleep step use LogActionImpl and have complete *.log files;
the second echo step uses LogStorageAction and log-index records its range.
@jglick
Avoid duplicated labels on blocks.
5854f54
@jglick
Merge branch 'master' into logs-JENKINS-38381
e830112
@jglick
Bumps.
f9325b5
@jglick
Under certain conditions behaviors can be repeatedly applied, so they…
46f8333 
… should be idempotent.
@jglick
Call AsynchronousExecution.completed even if saving build.xml fails. …
9e07b63 
…Also reduce scope of lock.
@svanoort
First hack at correcting the completion of the AsynchronousExecution
d08949e
@svanoort
Findbugs fix
877dafd
@svanoort
Fixes to completion logic
c6bd9b0
@jglick
Copy link
Member

jglick commented Oct 4, 2018

WorkflowRunRestartTest.lazyLoadExecution was one of the tests I noticed being flaky when I ran locally:

[WARNING] org.jenkinsci.plugins.workflow.job.WorkflowRunRestartTest.lazyLoadExecution(org.jenkinsci.plugins.workflow.job.WorkflowRunRestartTest)
[ERROR]   Run 1: WorkflowRunRestartTest.lambda$lazyLoadExecution$5:132 expected null, but was:<Owner[p/1:p #1]>
[ERROR]   Run 2: WorkflowRunRestartTest.lambda$lazyLoadExecution$5:132 expected null, but was:<Owner[p/1:p #1]>
[ERROR]   Run 3: WorkflowRunRestartTest.lambda$lazyLoadExecution$5:132 expected null, but was:<Owner[p/1:p #1]>
[ERROR]   Run 4: WorkflowRunRestartTest.lambda$lazyLoadExecution$5:132 expected null, but was:<Owner[p/1:p #1]>
[INFO]   Run 5: PASS

So probably just some sort of race condition.

@jglick
Copy link
Member

jglick commented Oct 4, 2018

FTR this is also jglick#3, but filed properly against the origin repo so that we get CI on it.

@svanoort
Copy link
Member Author

svanoort commented Oct 4, 2018

For whatever reason, what should be a trivial fix is not, and oddly the original does not trigger failures, so... I guess we roll with it.

@svanoort svanoort closed this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@svanoort @jglick @MarkEWaite @dwnusbaum