Skip to content

Test with Java 25 #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarkEWaite wants to merge 3 commits into from
Closed

Test with Java 25 #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22e50ac
Bump io.jenkins.tools.bom:bom-2.479.x
dependabot[bot] Nov 10, 2025
0bc8f09
Merge branch 'dependabot/maven/io.jenkins.tools.bom-bom-2.479.x-5054.…
MarkEWaite Nov 16, 2025
9731ef5
Test with Java 25 and Java 21
MarkEWaite Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ https://github.com/jenkins-infra/pipeline-library/
buildPlugin(
useContainerAgent: true, // Set to `false` if you need to use Docker for containerized tests
configurations: [
[platform: 'linux', jdk: 21],
[platform: 'windows', jdk: 17],
[platform: 'linux', jdk: 25],
[platform: 'windows', jdk: 21],
])
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-${jenkins.baseline}.x</artifactId>
<version>4023.va_eeb_b_4e45f07</version>
<version>5054.v620b_5d2b_d5e6</version>
Copy link
Member

@jtnord jtnord Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is broken in the current version of the bom that this needed to be updated (the commit history is inverted)?
#482

Copy link
Contributor Author

@MarkEWaite MarkEWaite Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is broken in bom-2.479.x 4023.va_eeb_b_4e45f07. The tests pass on Ubuntu Linux with Java 25 and fail two tests on Fedora Linux 43 whether using bom-2.479.x 4023.va_eeb_b_4e45f07 or bom-2.479.x 5054.v620b_5d2b_d5e6. Since 5054.v620b_5d2b_d5e6 is the final BOM version for bom-2.479.x, it seemed reasonable to update to that version rather than remaining on a much older version, but that update is optional for this pull request.

I updated the plugin BOM in this pull request as an inadvertent result of the test failures on Fedora Linux 43 where I was doing my testing. It wasn't until after I had explored further that I realized the test failures are specific to Fedora Linux 43 (at least in my configuration). I can remove the BOM upgrade if that will allow the change to be merged.

Copy link
Member

@jtnord jtnord Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if nothing is broken then #482 should suffice and we should be able to close this

<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down
Loading