Skip to content

Inherit describable logstorage from workflow-api #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandeepbarnwal wants to merge 2 commits into from
Closed

Inherit describable logstorage from workflow-api #464

sandeepbarnwal wants to merge 2 commits into from

Conversation

@sandeepbarnwal
Copy link

@sandeepbarnwal sandeepbarnwal commented Jul 28, 2025 •
edited
Loading

depends upon upstream jenkinsci/workflow-api-plugin#417

Changes

  • Modified log storage usage to inherit changes from upstream, implementing it as a describable component rather than as an extension

Note: It is kept in draft intentionally and will be ready for review once upstream is released .

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@sandeepbarnwal sandeepbarnwal force-pushed the logstorage-describable branch from 59ff4c0 to 41b0fb0 Compare July 29, 2025 10:17
@jgreffe
Copy link

jgreffe commented Jul 29, 2025 •
edited
Loading

Uses jenkinsci/workflow-api-plugin#417

dwnusbaum
dwnusbaum reviewed Jul 30, 2025
View reviewed changes
jgreffe
jgreffe reviewed Aug 5, 2025
View reviewed changes
Copy link

@jgreffe jgreffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve when upstream released.

@dwnusbaum dwnusbaum mentioned this pull request Aug 6, 2025
Closed
6 tasks
@dwnusbaum dwnusbaum closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwnusbaum dwnusbaum dwnusbaum left review comments

+2 more reviewers

@Amankkc Amankkc Amankkc left review comments

@jgreffe jgreffe jgreffe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sandeepbarnwal @jgreffe @dwnusbaum @Amankkc