Skip to content

Do not even try to use LogTaskListener #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 2 commits into from
Jul 28, 2023
Merged

Do not even try to use LogTaskListener #327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1612e43
Do not even try to use `LogTaskListener`
jglick Jul 28, 2023
a4d9083
Unused import
jglick Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/jenkinsci/plugins/workflow/steps/durable_task/DurableTaskStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import hudson.slaves.OfflineCause;
import hudson.util.DaemonThreadFactory;
import hudson.util.FormValidation;
import hudson.util.LogTaskListener;
import hudson.util.NamingThreadFactory;
import hudson.util.StreamTaskListener;
import java.io.FilterOutputStream;
Expand Down Expand Up @@ -430,11 +429,11 @@ private void getWorkspaceProblem(Exception x) {
LOGGER.log(Level.FINEST, "JENKINS-34021: DurableTaskStep.Execution.listener present in {0}", context);
} else {
LOGGER.log(Level.WARNING, "JENKINS-34021: TaskListener not available upon request in {0}", context);
l = new LogTaskListener(LOGGER, Level.FINE);
l = TaskListener.NULL;
}
} catch (Exception x) {
LOGGER.log(Level.FINE, "JENKINS-34021: could not get TaskListener in " + context, x);
l = new LogTaskListener(LOGGER, Level.FINE);
l = TaskListener.NULL;
recurrencePeriod = 0;
}
return l;
Expand Down