Use waitForMessage in tests to reduce flakes

[timja]

Hi we're experiencing flakey tests trying to integrate the next bom line,

example:

Expected: a string containing "broken condition"
     but: was "Started
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] Start of Pipeline
[Pipeline] waitUntil
[Pipeline] {
[Pipeline] semaphore
[Pipeline] }
Will try again after 0.25 sec
[Pipeline] {
[Pipeline] semaphore
[Pipeline] }
[Pipeline] // waitUntil
[Pipeline] End of Pipeline

@jglick suggested replacing assertLogContains with waitForMessage
jenkinsci/bom#110 (comment)

[jglick]

jenkinsci/workflow-support-plugin#105 (comment)

[jglick]

Also need

java.lang.AssertionError: 

Expected: a string containing "Timeout has been exceeded"
     but: was "Started
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] Start of Pipeline
[Pipeline] node
Running on Jenkins in /home/jenkins/workspace/Tools_bom_PR-110/pct-work/workflow-durable-task-step/target/tmp/j h7284083198078828316/workspace/p
[Pipeline] {
[Pipeline] timeout
Timeout set to expire in 1 sec
[Pipeline] {
[Pipeline] sh
+ sleep 5
Cancelling nested steps due to timeout
Sending interrupt signal to process
Terminated
script returned exit code 143
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.jvnet.hudson.test.JenkinsRule.assertLogContains(JenkinsRule.java:1396)
	at org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest.interruptingAbortsBuild(ShellStepTest.java:707)

[jglick]

see #136 (comment)

[dwnusbaum]

I think that jenkinsci/jenkins-test-harness#210, which is in the version of jenkins-test-harness used by this plugin, fixed all of these issues, so I am closing the PR. Feel free to reopen the PR if I am misunderstanding something.