Skip to content

[JENKINS-59152] Add test for abort of a nontrivial process hierarchy #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slonopotamus wants to merge 1 commit into from
Closed

[JENKINS-59152] Add test for abort of a nontrivial process hierarchy #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 61 additions & 15 deletions src/test/java/org/jenkinsci/plugins/workflow/steps/durable_task/ShellStepTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@
import java.util.logging.Level;
import java.util.logging.LogRecord;
import javax.annotation.CheckForNull;

import hudson.util.ProcessTree;
import jenkins.util.JenkinsJVM;
import org.apache.commons.lang.StringUtils;

Expand Down Expand Up @@ -205,6 +207,50 @@ public void abort() throws Exception {
j.assertBuildStatus(Result.ABORTED, j.waitForCompletion(b));
}

@Test
@Issue("JENKINS-59152")
public void abortDeepCmd() throws Exception {
Assume.assumeTrue(Functions.isWindows());
ProcessTree.enabled = true;

final WorkflowJob foo = j.createProject(WorkflowJob.class);
foo.setDefinition(new CpsFlowDefinition(
"node {\n" +
" parallel abort: {\n" +
" sleep time: 1\n" +
" currentBuild.result = 'ABORTED'\n" +
" error('Abort')\n" +
" },\n" +
" payload1: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" payload2: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" payload3: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" payload4: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" payload5: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" payload6: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" payload7: {\n" +
" bat 'cmd /c cmd /c cmd /c cmd /c cmd /c ping -n 10000 127.0.0.1'\n" +
" },\n" +
" failFast: true\n" +
"}"
));

for (int i = 0; i < 10; ++i) {
j.assertBuildStatus(Result.ABORTED, foo.scheduleBuild2(0));
}
}

@Issue("JENKINS-41339")
@Test public void nodePaths() throws Exception {
DumbSlave slave = j.createSlave("slave", null, null);
Expand Down Expand Up @@ -289,7 +335,7 @@ private static class Decorator extends LauncherDecorator implements Serializable
assertNull(s.getEncoding());
assertFalse(s.isReturnStatus());
assertEquals("", s.getLabel());

s.setReturnStdout(true);
s.setEncoding("ISO-8859-1");
s = new StepConfigTester(j).configRoundTrip(s);
Expand All @@ -298,7 +344,7 @@ private static class Decorator extends LauncherDecorator implements Serializable
assertEquals("ISO-8859-1", s.getEncoding());
assertFalse(s.isReturnStatus());
assertEquals("", s.getLabel());

s.setReturnStdout(false);
s.setEncoding("UTF-8");
s.setReturnStatus(true);
Expand All @@ -308,7 +354,7 @@ private static class Decorator extends LauncherDecorator implements Serializable
assertEquals("UTF-8", s.getEncoding());
assertTrue(s.isReturnStatus());
assertEquals("", s.getLabel());

s.setLabel("Round Trip Test");
s = new StepConfigTester(j).configRoundTrip(s);
assertEquals("echo hello", s.getScript());
Expand All @@ -334,12 +380,12 @@ private static class Decorator extends LauncherDecorator implements Serializable
p.setDefinition(new CpsFlowDefinition("node {echo \"truth is ${isUnix() ? sh(script: 'true', returnStatus: true) : bat(script: 'echo', returnStatus: true)} but falsity is ${isUnix() ? sh(script: 'false', returnStatus: true) : bat(script: 'type nonexistent' , returnStatus: true)}\"}", true));
j.assertLogContains("truth is 0 but falsity is 1", j.assertBuildStatusSuccess(p.scheduleBuild2(0)));
}


@Test public void label() throws Exception {
WorkflowJob p = j.jenkins.createProject(WorkflowJob.class, "p");
p.setDefinition(new CpsFlowDefinition("node {isUnix() ? sh(script: 'true', label: 'Step with label') : bat(script: 'echo', label: 'Step with label')}", true));

WorkflowRun b = j.assertBuildStatus(Result.SUCCESS, p.scheduleBuild2(0).get());

boolean found = false;
Expand All @@ -353,14 +399,14 @@ private static class Decorator extends LauncherDecorator implements Serializable

assertTrue(found);
}

@Test public void labelShortened() throws Exception {
String singleLabel= StringUtils.repeat("0123456789", 10);
String label = singleLabel + singleLabel;

WorkflowJob p = j.jenkins.createProject(WorkflowJob.class, "p");
p.setDefinition(new CpsFlowDefinition("node {isUnix() ? sh(script: 'true', label: '" + label + "') : bat(script: 'echo', label: '" + label + "')}", true));

WorkflowRun b = j.assertBuildStatus(Result.SUCCESS, p.scheduleBuild2(0).get());

boolean found = false;
Expand Down Expand Up @@ -664,7 +710,7 @@ private static final class HelloNote extends ConsoleNote<Run<?, ?>> {
assertNull(record.getThrown());
}
}

@Issue("JENKINS-49707")
@Test public void removingAgentIsFatal() throws Exception {
logging.record(DurableTaskStep.class, Level.FINE).record(FileMonitoringTask.class, Level.FINE).record(ExecutorStepExecution.class, Level.FINE);
Expand All @@ -681,13 +727,13 @@ private static final class HelloNote extends ConsoleNote<Run<?, ?>> {
@Issue("JENKINS-44521")
@Test public void shouldInvokeLauncherDecoratorForShellStep() throws Exception {
DumbSlave slave = j.createSlave("slave", null, null);

WorkflowJob p = j.jenkins.createProject(WorkflowJob.class, "p");
p.setDefinition(new CpsFlowDefinition("node('slave') {isUnix() ? sh('echo INJECTED=$INJECTED') : bat('echo INJECTED=%INJECTED%')}", true));
WorkflowRun run = j.buildAndAssertSuccess(p);

j.assertLogContains("INJECTED=MYVAR-" + slave.getNodeName(), run);

}

@Issue("JENKINS-28822")
Expand Down Expand Up @@ -735,7 +781,7 @@ private <T> void ensureForWhile(int timeout, T o, Predicate<T> predicate) throws
Thread.sleep(100);
}
}

@TestExtension(value = "shouldInvokeLauncherDecoratorForShellStep")
public static final class MyNodeLauncherDecorator extends LauncherDecorator {

Expand All @@ -745,7 +791,7 @@ public Launcher decorate(Launcher lnchr, Node node) {
Map<String, String> env = new HashMap<>();
env.put("INJECTED", "MYVAR-" + node.getNodeName());
return lnchr.decorateByEnv(new EnvVars(env));
}
}
}
}