Fix race condition in ShellStepTest.abort #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that build cancellation is async and build can touch the file between the moment when test read file modification time and build process was killed. Note that this commit doesn't fully fix test on Windows due to JENKINS-59152 that will be separately fixed in Jenkins Core.
Member
|
A slightly modified form of this was added in #137 to fix the test, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that build cancellation is async and build can touch the file
between the moment when test read file modification time and build process was killed.
Note that this commit doesn't fully fix test on Windows due to JENKINS-59152.