Skip to content

Remove flaky assertion from FlowDurabilityTest.verifyExecutionRemoved#784

Merged
jglick merged 1 commit intojenkinsci:masterfrom
jglick:FlowDurabilityTest.verifyExecutionRemoved
Sep 8, 2023
Merged

Remove flaky assertion from FlowDurabilityTest.verifyExecutionRemoved#784
jglick merged 1 commit intojenkinsci:masterfrom
jglick:FlowDurabilityTest.verifyExecutionRemoved

Conversation

@jglick
Copy link
Member

@jglick jglick commented Sep 8, 2023

FlowDurabilityTest.testResumeBlocked and .testResumeBlockedAddedAfterRunStart frequently fail in PCT

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest.verifyExecutionRemoved(FlowDurabilityTest.java:219)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest.verifyCompletedCleanly(FlowDurabilityTest.java:370)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest.verifyFailedCleanly(FlowDurabilityTest.java:344)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest$21.evaluate(FlowDurabilityTest.java:778)
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest.verifyExecutionRemoved(FlowDurabilityTest.java:219)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest.verifyCompletedCleanly(FlowDurabilityTest.java:370)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest.verifyFailedCleanly(FlowDurabilityTest.java:344)
	at org.jenkinsci.plugins.workflow.cps.FlowDurabilityTest$23.evaluate(FlowDurabilityTest.java:808)

I am not exactly sure why, but do we really need to be using reflection here? We do not really care about the internal field, so long as the visible effect is that the build is gone. ItemListenerImpl does cleanup (see jenkinsci/workflow-api-plugin#304).

@jglick jglick requested a review from a team as a code owner September 8, 2023 21:15
@jglick jglick requested review from Vlatombe and dwnusbaum September 8, 2023 21:15
@jglick jglick merged commit 8f5dcd1 into jenkinsci:master Sep 8, 2023
@jglick jglick deleted the FlowDurabilityTest.verifyExecutionRemoved branch September 8, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants