Skip to content

Conversation

@basil
Copy link
Member

@basil basil commented Aug 1, 2021

Discovered in jenkinsci/bom#423. Like jenkinsci/workflow-support-plugin#114 and jenkinsci/git-client-plugin#686, but for workflow-basic-steps.

workflow-basic-steps previously used MoreExecutors#sameThreadExecutor from Guava, which was removed in version 21.0 in favor of MoreExecutors#newDirectExecutorService. This PR uses reflection to first try to call MoreExecutors#newDirectExecutorService but then call MoreExecutors#sameThreadExecutor if the first method is not available to support both older and newer versions of Guava.

@basil basil closed this Aug 1, 2021
@basil basil reopened this Aug 1, 2021
timja added a commit to timja/bom that referenced this pull request Aug 2, 2021
@timja
Copy link
Member

timja commented Aug 2, 2021

@jenkinsci/workflow-basic-steps-plugin-developers please

@timja timja mentioned this pull request Aug 2, 2021
@timja
Copy link
Member

timja commented Aug 2, 2021

@basil you may want to pull in #149 as well, incremental doesn't work otherwise in bom for PCT

I've created #150 anyway

@timja timja mentioned this pull request Aug 2, 2021
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably OK though

// TODO would use Futures.addCallback but this is still @Beta in Guava 19 and the Pipeline copy is in workflow-support on which we have no dep

@timja
Copy link
Member

timja commented Aug 9, 2021

@car-roll

@car-roll car-roll merged commit 26ca2e8 into jenkinsci:master Aug 9, 2021
@basil basil deleted the guava branch August 9, 2021 18:23
@timja
Copy link
Member

timja commented Aug 13, 2021

@car-roll is it possible to get a release please?

Ideally including #144

@car-roll
Copy link

@timja no problem, once i've finished going through #144, and the other approvals clear, I'll do a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants