[JENKINS-54128] Define an SPI in LogStorage to satisfy WorkflowRun.getLogFile #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
added a commit
to jglick/workflow-job-plugin
that referenced
this pull request
Nov 9, 2018
jglick
added a commit
to jglick/pipeline-cloudwatch-logs-plugin
that referenced
this pull request
Nov 9, 2018
svanoort
reviewed
Nov 9, 2018
svanoort
approved these changes
Nov 9, 2018
Member
svanoort
left a comment
svanoort
left a comment
There was a problem hiding this comment.
Looks okay to me, module one quirk. Good implementation because it means that other log implementations get flexibility for how to handle the logFile
dwnusbaum
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out of jenkinsci/workflow-job-plugin#118 at @svanoort’s request.