Skip to content

Conversation

@jglick
Copy link
Member

@jglick jglick commented Jul 11, 2018

Follows up #67.

Copy link
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just pending tests

@jglick
Copy link
Member Author

jglick commented Jul 11, 2018

Passed, though this code is not run in this plugin’s own tests; exercised here.

@svanoort svanoort merged commit 540d860 into jenkinsci:master Jul 11, 2018
@jglick jglick deleted the empty-stash-JENKINS-52361 branch July 11, 2018 20:18
jglick added a commit to jenkinsci/artifact-manager-s3-plugin that referenced this pull request Jul 24, 2018
jglick added a commit to jenkinsci/artifact-manager-s3-plugin that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants