Skip to content

[JENKINS-49635] VirtualFile support #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svanoort merged 49 commits into from
Jun 15, 2018
Merged

[JENKINS-49635] VirtualFile support #67

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
e53c48e
[JENKINS-49635] Added DirectArtifactManagerFactory test utility.
jglick Feb 28, 2018
2dd13bc
Working on ArtifactManagerTest.
jglick Mar 2, 2018
f06ee84
Rudimentary tests of VirtualFile.list overloads.
jglick Mar 12, 2018
98fef1a
Support stashes with remote artifact managers.
jglick Mar 13, 2018
5b86b27
Updates.
jglick Mar 14, 2018
4be635c
@oleg-nenashev suggests a fuller envFor implementation.
jglick Mar 14, 2018
2e6480b
Emphasizing that launcherFor and envFor are only called from deprecat…
jglick Mar 14, 2018
02f4e4d
Also testing toExternalURL.
jglick Mar 14, 2018
25bf80d
Strengthening test to cover stash & artifact deletion.
jglick Mar 15, 2018
afe16e3
Working on tests.
jglick Mar 15, 2018
ffcf02c
More tests.
jglick Mar 15, 2018
979b266
More tests.
jglick Mar 15, 2018
8fb822a
Stronger tests.
jglick Mar 16, 2018
3b63b81
More streamlined assertion of file contents.
jglick Mar 16, 2018
1da7d9a
Allow callers to decide whether to test weird characters or not.
jglick Mar 16, 2018
bcef72c
assertNonexistent
jglick Mar 16, 2018
ee7386f
Also testing VirtualFile.run(Callable) overrides.
jglick Mar 23, 2018
cb9e41e
useBeta
jglick Mar 26, 2018
70472c4
Mark StashAwareArtifactManager as beta for now, too.
jglick Mar 26, 2018
e29a3de
Testing toExternalURL rather than asRemotable.
jglick Apr 2, 2018
9003240
Picking up https://github.com/jenkinsci/plugin-pom/pull/98.
jglick Apr 3, 2018
915f652
Run artifact upload and download operations using a Dockerized agent …
jglick Apr 4, 2018
bb4098a
Porting https://github.com/jglick/workflow-api-plugin/pull/1 by @carl…
jglick Apr 4, 2018
bfe1842
Nonsensical to build against 2.89 when the baseline is a trunk snapshot.
jglick Apr 4, 2018
17887af
As with DockerClassRule, it seems necessary to be calling Docker.buil…
jglick Apr 4, 2018
dfea773
docker-fixtures 1.7
jglick Apr 5, 2018
54f2a2a
Merge branch 'master' into VirtualFile-JENKINS-49635
jglick Apr 16, 2018
395471c
Updated.
jglick Apr 16, 2018
f5cebc7
Merge branch 'master' into VirtualFile-JENKINS-49635
jglick Apr 23, 2018
44bc998
jenkins.version=2.118
jglick Apr 23, 2018
0675e9e
Preparing for Incrementals.
jglick Apr 27, 2018
77c72ff
Picking up https://github.com/jenkinsci/plugin-pom/pull/105.
jglick May 9, 2018
8e8a4c1
[JENKINS-51187] Moving git-changelist-maven-extension into incrementa…
jglick May 10, 2018
67900f6
Updates.
jglick May 11, 2018
8abe7c5
Incrementals tweaks, and may as well use an actual LTS baseline.
jglick May 16, 2018
1dfffb2
Split tests so implementations can choose
carlossg May 25, 2018
0cc8c11
Use lambdas
carlossg May 28, 2018
aa3ab38
Improve javadoc for test methods
carlossg May 28, 2018
90cc5dc
The standard manager does implement delete, so meant to call artifact…
jglick May 29, 2018
d37cbf7
Improved Javadoc for ArtifactManagerTest.
jglick Jun 1, 2018
e9b9e06
Improving DirectArtifactManagerFactory to serve actual HTTP URLs.
jglick Jun 5, 2018
175399c
Javadoc improvements.
jglick Jun 8, 2018
afd2797
Clarifying the expected usage of StashAwareArtifactManager.
jglick Jun 8, 2018
ebc0383
Merge branch 'incrementals' into VirtualFile-JENKINS-49635
jglick Jun 11, 2018
e54f030
More info on JCloudsArtifactManager.
jglick Jun 13, 2018
72d360f
Merge branch 'master' into VirtualFile-JENKINS-49635
jglick Jun 15, 2018
ea15b85
More strongly worded message.
jglick Jun 15, 2018
5b88a0d
Javadocs clarification
svanoort Jun 15, 2018
11b84be
Merge pull request #3 from svanoort/remote-docs
jglick Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/org/jenkinsci/plugins/workflow/flow/StashManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,12 @@ public boolean shouldClearAll(@Nonnull Run<?,?> build) {

/**
* Mixin interface for an {@link ArtifactManager} which supports specialized stash behavior as well.
* The recommended standard implementation is in the plugin currently named {@code artifact-manager-s3},
* which in turn supports extensibility to various cloud providers.
* <p>The recommended standard implementation is {@code JCloudsArtifactManager}
Copy link
Member

@svanoort svanoort Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick This is still not what we had discussed.

* in the plugin currently named {@code artifact-manager-s3}.
* This in turn supports extensibility to various cloud providers,
* and handles all aspects of making cloud artifact storage work smoothly in Jenkins
* including the {@link VirtualFile} implementation, robust network error handling,
* overall configuration UI, and more.
* @see <a href="https://github.com/jenkinsci/jep/blob/master/jep/202/README.adoc">JEP-202</a>
*/
@Restricted(Beta.class)
Expand Down