Switch to POM properties for Pipeline-related dep versions #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on tooling to do testing of core + groovy-sandbox + groovy-cps + workflow-cps + script-security + the rest of the main Pipeline plugins against bleeding-edge versions of each other and different versions of Groovy. To do this, it'd be a lot easier if the dependencies between the various things I'm building/testing had their versions controlled by properties.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Member
svanoort
requested changes
Aug 4, 2017
Member
svanoort
left a comment
svanoort
left a comment
There was a problem hiding this comment.
Replace a nice, readable version with one that's taken from a variable stored far away in properties, making it hard to skim through dependencies?
No, there's plenty of ways to work with XML if you want to play with versions in an automated fashion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on tooling to do testing of core + groovy-sandbox +
groovy-cps + workflow-cps + script-security + the rest of the main
Pipeline plugins against bleeding-edge versions of each other and
different versions of Groovy. To do this, it'd be a lot easier if the
dependencies between the various things I'm building/testing had their
versions controlled by properties.
cc @reviewbybees