Skip to content

In case of a large FlowExecutionList, logging everything to warning level is too verbose #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwnusbaum merged 1 commit into from
Jan 10, 2025
Merged

In case of a large FlowExecutionList, logging everything to warning level is too verbose #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,12 @@
FlowExecutionList list = FlowExecutionList.get();
FlowExecutionOwner owner = e.getOwner();
if (!list.runningTasks.contains(owner)) {
LOGGER.log(Level.WARNING, "Resuming {0}, which is missing from FlowExecutionList ({1}), so registering it now.", new Object[] {owner, list.runningTasks.getView()});
if (LOGGER.isLoggable(Level.FINE)) {

Check warning on line 311 in src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 311 is only partially covered, one branch is missing
// Still a warning, but give more details for debugging
LOGGER.log(Level.WARNING, () -> "Resuming " + owner + ", which is missing from FlowExecutionList (" + list.runningTasks.getView() + "), so registering it now.");
} else {
LOGGER.log(Level.WARNING, () -> "Resuming " + owner + ", which is missing from FlowExecutionList, so registering it now.");

Check warning on line 315 in src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 315 is not covered by tests
}
list.register(owner);
}
LOGGER.log(Level.FINE, "Will resume {0}", result);
Expand Down
Loading