Skip to content

Suppress warning about lack of OutputStreamTaskListener for core impls #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 2 commits into from
Jul 28, 2023
Merged

Suppress warning about lack of OutputStreamTaskListener for core impls #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f6a06
Suppress warning out lack of `OutputStreamTaskListener` for core impls
jglick Jul 28, 2023
a4d8dd5
Forgot `TaskListener.NULL`
jglick Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/java/org/jenkinsci/plugins/workflow/log/OutputStreamTaskListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
package org.jenkinsci.plugins.workflow.log;

import edu.umd.cs.findbugs.annotations.NonNull;
import hudson.model.StreamBuildListener;
import hudson.model.TaskListener;
import hudson.util.LogTaskListener;
import hudson.util.StreamTaskListener;
import java.io.FilterOutputStream;
import java.io.OutputStream;
import java.io.PrintStream;
Expand All @@ -34,6 +37,7 @@
import java.nio.charset.StandardCharsets;
import java.util.logging.Level;
import java.util.logging.Logger;
import jenkins.util.BuildListenerAdapter;
import org.apache.commons.io.output.ClosedOutputStream;
import org.kohsuke.accmod.Restricted;
import org.kohsuke.accmod.restrictions.Beta;
Expand Down Expand Up @@ -64,7 +68,13 @@ public interface OutputStreamTaskListener extends TaskListener {
return ps;
}
if (Runtime.version().compareToIgnoreOptional(Runtime.Version.parse("17")) >= 0) {
Logger.getLogger(OutputStreamTaskListener.class.getName()).warning(() -> "On Java 17+ error handling is degraded unless OutputStreamTaskListener is used: " + listener.getClass().getName());
boolean core = // nothing to be done about these, though they should not be used in Pipeline build logs anyway
listener == TaskListener.NULL ||
listener.getClass() == StreamTaskListener.class ||
listener.getClass() == LogTaskListener.class ||
listener.getClass() == StreamBuildListener.class ||
listener.getClass() == BuildListenerAdapter.class;
Logger.getLogger(OutputStreamTaskListener.class.getName()).log(core ? Level.FINE : Level.WARNING, () -> "On Java 17+ error handling is degraded unless OutputStreamTaskListener is used: " + listener.getClass().getName());
return ps;
}
Field printStreamDelegate;
Expand Down