Catch errors in TaskListenerDecorator.decorate even when wrapped with merge
#290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
approved these changes
Jul 12, 2023
src/main/java/org/jenkinsci/plugins/workflow/log/TaskListenerDecorator.java
Show resolved
Hide resolved
rsandell
approved these changes
Jul 12, 2023
jtnord
approved these changes
Jul 12, 2023
jglick
commented
Jul 12, 2023
Member
Author
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Got GitHub into a weird corner case where I have zero pending changes yet still have a pending review I need to cancel and cannot do so without leaving a comment.
11 tasks
jglick
added a commit
to jglick/workflow-durable-task-step-plugin
that referenced
this pull request
Jul 12, 2023
jglick
added a commit
to jglick/credentials-binding-plugin
that referenced
this pull request
Jul 27, 2023
…ar indication of the plugin bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/gradle-plugin#318 for context. Do not risk having a decorator be completely skipped just because an unrelated decorator was erroneous.