Skip to content

[JENKINS-39314] Fix env vars set in other build environments not being passed to the current one. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calin-iorgulescu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-39314] Fix env vars set in other build environments not being passed to the current one. #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/main/java/hudson/plugins/templateproject/ProxyBuildEnvironment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.Map;

import org.kohsuke.stapler.AncestorInPath;
import org.kohsuke.stapler.DataBoundConstructor;
Expand Down Expand Up @@ -84,12 +85,20 @@ public Environment setUp(@SuppressWarnings("rawtypes") AbstractBuild build, Laun

AbstractProject p = TemplateUtils.getProject(getProjectName(), build);
listener.getLogger().println("[TemplateProject] Getting environment from: " + HyperlinkNote.encodeTo('/'+ p.getUrl(), p.getFullDisplayName()));
final ArrayList<Environment> envs = new ArrayList<Environment>();
for (BuildWrapper builder : getProjectBuildWrappers(build)) {
builder.setUp(build, launcher, listener);
envs.add(builder.setUp(build, launcher, listener));
}
listener.getLogger().println("[TemplateProject] Successfully setup environment from: '" + p.getFullDisplayName() + "'");

return new Environment() {
@Override
public void buildEnvVars(Map<String, String> vars) {
for (Environment env : envs) {
env.buildEnvVars(vars);
}
}

@Override
public boolean tearDown(@SuppressWarnings("rawtypes") AbstractBuild build, BuildListener listener) throws IOException, InterruptedException {
// let build continue
Expand Down