Skip to content

Fix SlaveCommandStatistics memory leak with some commands #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jglick merged 9 commits into from
Jan 8, 2026
Merged

Fix SlaveCommandStatistics memory leak with some commands #943

jglick merged 9 commits into from
Jan 8, 2026
+160 −6

Conversation

@apuig
Copy link
Contributor

@apuig apuig commented Dec 30, 2025

  • Update IRRELEVANT pattern to strip bracket parameters
  • Add MAX_ENTRIES_PER_AGENT=1000 cap with preferringOlder strategy
  • Add MAX_COMMAND_LENGTH=256 truncation (tunable via system properties)

Fixes #942

References:
#128
#180
jenkinsci/jenkins#9921

Testing done

The tests include actual commands found in support bundles.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@apuig
Fix SlaveCommandStatistics memory leak with some commands
0eeb67a 
- Update IRRELEVANT pattern to strip bracket parameters
- Add MAX_ENTRIES_PER_AGENT=1000 cap with preferringOlder strategy
- Add MAX_COMMAND_LENGTH=256 truncation (tunable via system properties)
@apuig apuig requested a review from a team as a code owner December 30, 2025 18:33
@jglick jglick added the bug label Dec 30, 2025
jglick
jglick approved these changes Dec 30, 2025
View reviewed changes
@jglick jglick enabled auto-merge January 2, 2026 14:18
@apuig
Copy link
Contributor Author

apuig commented Jan 7, 2026 •
edited
Loading

The last 3 builds have failed at SupportActionTest.takeSnapshotAndMakeSureSomethingHappens (in windows, with a timeout). This issue appears to be unrelated to the current change, as new tests were run after this failure. Is there anything I can do to help move this forward?

@jglick jglick mentioned this pull request Jan 7, 2026
Closed
@jglick
Copy link
Member

jglick commented Jan 7, 2026

I think that is being investigated in #944.

@jglick jglick merged commit a4ab174 into jenkinsci:master Jan 8, 2026
17 of 18 checks passed
@apuig apuig mentioned this pull request Jan 8, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick approved these changes

@Dohbedoh Dohbedoh Dohbedoh approved these changes

+1 more reviewer

@gbhat618 gbhat618 gbhat618 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SlaveCommandStatistics Memory Leak with certain Docker Commands

4 participants

@apuig @jglick @Dohbedoh @gbhat618