Inline Guava's Iterators#limit
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Apr 26, 2021
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Seems OK though I am unsure of the policy for inlining APL code into what is otherwise a BSD-2-Clause module. I would be inclined to just rewrite this one usage as I suspect that given the Javadoc any competent Java programmer could reimplement it (and we presumably do not even need all of it, like remove and IllegalArgumentException, just the very basic functionality).
Member
Author
|
I really don't think this is an issue, but if someone wants to reimplement this then feel free. |
Member
|
FYI @jtnord |
Member
|
As long as the license header is kept intact it would be ok I expect? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subset of #213 that is hopefully non-controversial and safe to land in the short term because it does not involve Caffeine or shading.