Skip to content

bump bom and jenkins version #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jglick merged 2 commits into from
Jul 25, 2022
Merged

bump bom and jenkins version #142

jglick merged 2 commits into from
Jul 25, 2022

Conversation

@jetersen
Copy link
Member

@jetersen jetersen commented Jul 22, 2022 •
edited
Loading

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jetersen
Copy link
Member Author

jetersen commented Jul 22, 2022 •
edited
Loading

Could use a branch for backporting it to 277.x

@jglick

@jetersen jetersen changed the base branch from master to 277.x July 22, 2022 21:04
jglick
jglick reviewed Jul 22, 2022
View reviewed changes
pom.xml
<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.289.3</jenkins.version>
<jenkins.version>2.319.3</jenkins.version>
Copy link
Member

@jglick jglick Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#133 in the next release, https://github.com/jenkinsci/ssh-credentials-plugin/releases/tag/287.v0c2c2889c28d, bumps up to 2.346.x. So this update would be exposed to 2.319.x and 2.332.x users. OK I think, though it is unusual to change core dep in a backport branch.

@jglick
Copy link
Member

jglick commented Jul 22, 2022

RequireUpperBoundDeps error

@jglick
Copy link
Member

jglick commented Jul 22, 2022

jenkins-infra/github-reusable-workflows#14 🍿

@jglick
Copy link
Member

jglick commented Jul 22, 2022

Going to have to wait until Monday I am afraid. 👋

@jetersen
Copy link
Member Author

jetersen commented Jul 22, 2022 •
edited
Loading

Jenkins CI is like:

Skipping deployment as no artifacts were found with the expected path, typically due to a PR merge build not up to date with its base branch

Me:

Excuse me? Pug looking confused at you

@jglick no worries I can test with an incremental... Hopefully

This was referenced Jul 22, 2022
Merged
Closed
@jetersen
Copy link
Member Author

jetersen commented Jul 23, 2022 •
edited
Loading

Confirmed that it is working: jenkinsci/bom#1275

@jetersen
Copy link
Member Author

jetersen commented Jul 23, 2022

/reviewer jglick,car-roll

@comment-ops-bot comment-ops-bot bot requested review from car-roll and jglick July 23, 2022 07:54
@jglick jglick merged commit 1e86b7d into jenkinsci:277.x Jul 25, 2022
@jetersen jetersen deleted the bumpBom branch July 25, 2022 15:12
@jglick
Copy link
Member

jglick commented Jul 25, 2022

https://github.com/jenkinsci/ssh-credentials-plugin/releases/tag/277.280.v1e86b_7d0056b_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick Awaiting requested review from jglick

@car-roll car-roll Awaiting requested review from car-roll

Assignees

No one assigned

Labels

developer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jetersen @jglick