Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Jan 14, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@jetersen
Copy link
Member

@dwnusbaum chance we could get a review/merge only one left blocking jenkinsci/bom#172 😅

@timja
Copy link
Member Author

timja commented Jan 20, 2020

@dwnusbaum chance we could get a review/merge only one left blocking jenkinsci/bom#172 😅

there's a few more 😉, the pipeline has failFast on the parallel block, each one we fix reveals more failures,

but would be great to get a review / merge / release

@timja timja requested review from abayer and bitwiseman January 20, 2020 20:01
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The new artifact pulls in a ton of dependencies, most notably jackson-databind, but we should never use any of those dependencies in this plugin in compile scope so I don't anticipate any conflicts that might require transitive dependencies to be excluded or anything.

@dwnusbaum dwnusbaum requested a review from car-roll January 21, 2020 15:46
@timja
Copy link
Member Author

timja commented Jan 23, 2020

@dwnusbaum could you merge and release pretty please ❤️

@timja
Copy link
Member Author

timja commented Jan 24, 2020

or @bitwiseman :)

@dwnusbaum
Copy link
Member

@timja My plan is to release this in the next week or so.

@dwnusbaum dwnusbaum merged commit 6be6cee into jenkinsci:master Jan 27, 2020
@timja timja deleted the upgrade-jcasc branch January 27, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants