Convert to maven and auto-release #6
Conversation
- Convert from building with Gradle to Maven. - Update plugin for continuous automated release.
samrocketman
force-pushed
the
auto-release
branch
from
4d03043 to
610decb
Compare
Repository link --------------- https://github.com/jenkinsci/scm-filter-jervis-plugin Enabling auto-release --------------------- See my PR; please review jenkinsci/scm-filter-jervis-plugin#6 My checklist: - [x] I have provided a link to the pull request in my plugin, which enables CD according to the documentation. Reviewer checklist ------------------ - [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access. - [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer. - [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer. There are [IRC Bot commands](https://jenkins.io/projects/infrastructure/ircbot/#issue-tracker-management) for it.
samrocketman
force-pushed
the
auto-release
branch
from
44495c6 to
61b02b9
Compare
samrocketman
force-pushed
the
auto-release
branch
from
3df95c4 to
cfba5ce
Compare
samrocketman
force-pushed
the
auto-release
branch
from
cfba5ce to
1c6e5e7
Compare
|
@timja I can't get this plugin to work in the latest version of Jenkins. I can bootstrap the latest version of jenkins and install this plugin. No filter traits show up in GitHub branch source plugin. It worked in Gradle; it currently does not work building with Maven. |
|
I verified the jars are in the classpath via script console. import net.gleske.jervis.tools.AutoRelease
import net.gleske.scmfilter.credential.GraphQLTokenCredential
AutoRelease.getScriptFromTemplate('${hello} ${world}', [hello: 'goodbye', world: 'friend'])I'm a bit stumped as to why the filter doesn't show up as an SCM filter trait. I can't release it in this condition... |
|
In the new Jar I see edit: scm-filter-branch-pr-plugin has the same thing and it works so I don't think that's it. |
|
I guess the next thing to try is look to other plugins using maven to compile groovy like job-dsl. |
|
Switching to GMavenPlus (which is what Job DSL plugin uses to compile groovy) fixed everything. I also upgraded to Java bytecode to Java 1.8. It took a bit for me to figure out how and I documented this process in a false bug report groovy/GMavenPlus#256 |
2 participants
Relates to jenkinsci/snakeyaml-api-plugin#75
I'll need to make a followup release for snakeyaml fix (after autorelease). There will be breaking code changes for the jervis library update (jervis 1.7 -> jervis 2.0) so this should be a separate PR.