Skip to content

Conversation

@jglick
Copy link
Member

@jglick jglick commented Mar 26, 2018

Downstream of jenkinsci/lib-access-modifier#11.

@reviewbybees @jenkinsci/code-reviewers

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

Needs a similar PR to https://github.com/jenkinsci/pom or the Jenkins Core

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<properties>
<jenkins.version>2.60.3</jenkins.version>
<java.level>8</java.level>
<maven-hpi-plugin.disabledTestInjection>true</maven-hpi-plugin.disabledTestInjection>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is just to shave off some build time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@jglick
Copy link
Member Author

jglick commented Mar 27, 2018

Needs a similar PR to https://github.com/jenkinsci/pom or the Jenkins Core

jenkinsci/jenkins@2090468 in jenkinsci/jenkins#3302 uses it.

@jglick jglick merged commit 6262f21 into jenkinsci:master Apr 3, 2018
@jglick jglick deleted the beta branch April 3, 2018 15:36
jglick added a commit to jglick/workflow-api-plugin that referenced this pull request Apr 3, 2018
jglick added a commit to jglick/compress-artifacts-plugin that referenced this pull request Apr 3, 2018
jglick added a commit to jenkinsci/artifact-manager-s3-plugin that referenced this pull request Apr 3, 2018
jglick added a commit to jglick/copyartifact-plugin that referenced this pull request Apr 3, 2018
jglick added a commit to jglick/workflow-basic-steps-plugin that referenced this pull request Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants