Skip to content

[JENKINS-48466] Provide JUnit 5 support for JenkinsRule #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basil merged 2 commits into from
Jul 18, 2022
Merged

[JENKINS-48466] Provide JUnit 5 support for JenkinsRule #560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4128227
[JENKINS-48466] Provide JUnit 5 support for `JenkinsRule`
basil Jun 16, 2022
2ad0a5c
Merge remote-tracking branch 'origin/master' into jupiter
basil Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@

<!-- Filled in by "maven-hpi-plugin" with the path to "org-netbeans-insane-hook.jar" extracted from "jenkins-test-harness" -->
<jenkins.insaneHook />
<jenkins-test-harness.version>1812.v6d4e97d91fd8</jenkins-test-harness.version>
<jenkins-test-harness.version>1813.v14f5db_a_f2b_d3</jenkins-test-harness.version>

<hpi-plugin.version>3.28</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
Expand Down Expand Up @@ -164,9 +164,11 @@
<version>3.1.0</version>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
Copy link
Member

@jetersen jetersen Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason this was removed from dependency management?

junit-bom does not include a junit version

<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.8.2</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.codehaus.mojo</groupId>
Expand Down Expand Up @@ -264,8 +266,13 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down