[JENKINS-56321] Scan detached plugins to get proper group id

[raul-arabaolaza]

JENKINS-56321

Detached plugins are added with default group id, this makes jaxb to be added with the wrong group id. Given that detached are always embedded into the war it makes sense to also scan group ids for detached plugins as is done for embedded ones. As a result, any detached plugin with a group id different from org.jenkins-ci.plugins (like 'jaxb) is going to be properly added

[oleg-nenashev]

lgtm

[v1v]

I guess the - char could be moved as below:

Suggested change

	m = Pattern.compile("WEB-INF/(?:(optional-|detached-))?plugins/([^/.]+)[.][hj]pi").matcher(name);
	m = Pattern.compile("WEB-INF/(?:(optional|detached)-)?plugins/([^/.]+)[.][hj]pi").matcher(name);

Although, It's not a blocker from my PoV

[alecharp]

By the way, is - character a special character or only when between []?

[jglick]

This change seems to have had the perhaps unexpected effect of making it so that if you just pass -war but not -includePlugins, PCT will now be run against detached plugins (which are not included as WEB-INF/plugins/*.hpi), which will likely fail since those versions are so old they can no longer be built with current dependency and tool versions.

[oleg-nenashev]

@jglick please create a JIRA ticket for it.

We have already fixed some regressions in #140 , but not the one you mentioned (I do not have use-cases for runs without -includePlugins). One of the mitigations we apply is to always have an integration test for new changes.

[jglick]

I will see. If I stop using CWP as in jenkinsci/custom-war-packager#108 then I think I do not care about this anyway since I could just make the WAR contain exactly what I need.