Allow tests to run locally using SSO #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jul 18, 2023
| Credentials credentials = builder.build().assumeRole(new AssumeRoleRequest(). | ||
| withRoleArn(role). | ||
| withRoleSessionName("CloudWatchSender"). // TODO does this need to be unique? | ||
| withRoleSessionName("CloudWatchSender-" + UUID.randomUUID()). |
Member
Author
There was a problem hiding this comment.
Just improving this while I was here, based on log message below.
jglick
commented
Feb 20, 2025
src/test/java/io/jenkins/plugins/pipeline_cloudwatch_logs/PipelineBridgeTest.java
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to jenkinsci/artifact-manager-s3-plugin#351 but more complicated here as a facility needed to be added to allow
AssumeRoleto be run on SSO session credentials that already had ansso_role_namedefined. (jenkinsci/workflow-api-plugin#296 (comment))