In some cases previous test result per stage can't be resolved, adding more diagnostics #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g more diagnostics
jglick
reviewed
Dec 20, 2024
Comment on lines
+137
to
+138
| Run<?,?> run = tr.getRun(); | ||
| if (stageName != null) { |
Member
There was a problem hiding this comment.
Suggested change
| Run<?,?> run = tr.getRun(); | |
| if (stageName != null) { | |
| if (stageName != null) { | |
| Run<?,?> run = tr.getRun(); |
jglick
reviewed
Dec 20, 2024
| FlowNode stageId = new DepthFirstScanner().findFirstMatch(execution, new StageNamePredicate(stageName)); | ||
| if (stageId != null) { | ||
| listener.getLogger().println("Found stage \"" + stageName + "\" in " + run.getFullDisplayName()); | ||
| tr = ((hudson.tasks.junit.TestResult) tr).getResultForPipelineBlock(stageId.getId()); |
Member
There was a problem hiding this comment.
Does this cast need to be checked?
jglick
reviewed
Dec 20, 2024
Comment on lines
+158
to
+159
| if (prevRun instanceof FlowExecutionOwner.Executable) { | ||
| FlowExecutionOwner owner = ((FlowExecutionOwner.Executable) prevRun).asFlowExecutionOwner(); |
jglick
reviewed
Dec 20, 2024
Comment on lines
+206
to
207
| if (targetBranch instanceof Job) { | ||
| result = getTestResult(project, ((Job<?, ?>) targetBranch).getLastBuild(), listener); |
jglick
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed in some cases that despite a valid stage name is specified, I don't get the corresponding logs being displayed (
Found stage ...,No stage ...), indicating that there may be an issue during the resolution ofFlowExecution.For now, adding more diagnostics so that on next occurrence I can pinpoint the issue better.
Testing done
Submitter checklist