Skip to content

Conversation

@cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Dec 19, 2023

Bump Jenkins Core to 2.401 + Add support for OutputStreamTaskListener

Fix for:

Build will pass after merging:

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
@kuisathaverat
Copy link
Contributor

kuisathaverat commented Dec 22, 2023

related to changes in the workflow plugin jenkinsci/workflow-api-plugin#294 and jenkinsci/workflow-durable-task-step-plugin#323

@cyrille-leclerc
Copy link
Contributor Author

@kuisathaverat it's ready for review. I can't say we improve the readability of the code. the nuances between BuildListener and TaskListener didn't help us 😄

@kuisathaverat
Copy link
Contributor

I will take a look next week, overall LGTM, but I want to make a manual test of everything.

@kuisathaverat kuisathaverat merged commit 33995ad into master Dec 28, 2023
@kuisathaverat kuisathaverat deleted the bump-jenkins-core-2.401 branch December 28, 2023 12:17
@kuisathaverat kuisathaverat added the bug Something isn't working label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants