Plugins should use slf4j-api version from Jenkins core #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRamonLeon
approved these changes
Jan 8, 2021
alecharp
approved these changes
Jan 8, 2021
This was referenced Mar 12, 2021
alecharp
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joseblas was testing a version of this plugin that included #70, and I noticed that he had to add an explicit dependency on
slf4j-apito solve an upper bounds conflict between this plugin and core, which should not be necessary. The problem appears to be the way dependency conflicts were fixed in 38c3baa. Sinceslf4j-apiis in the core BOM, any conflicts with it in a plugin must be solved by excluding the dependency from all paths other than core, which in this case means that all of the Dropwizard metrics library dependencies need an exclusion.At runtime, the version from Jenkins core is what is going to be used anyway, so trying to resolve the
slf4j-apiconflicts here by requesting a different version independencyManagementdoes not actually fix the conflicts, it just hides them, and it means that any plugin that depends onmetricsplugin is likely to run into the same upper bounds issues.