Skip to content

Conversation

@batmat
Copy link
Member

@batmat batmat commented Nov 9, 2020

(Edited description after the fact, for better up-front clarity)

For some unclear reason iI did not spend hours investigating, #58 PR was green. BUT the master branch started failing when it got merged.

The reason is that the jenkins.version in one combinatorial of recommendedConfiguration (2.164, which is older than jenkins.version of the metrics-plugin currently).is more

This PR is fixing the Jenkinsfile by "exploding" the recommendedConfiguration with the various axis to be tested. This way we have control on the LTS to use (and it's bumped to the one declared in the pom.xml).

@alecharp
Copy link
Member

I know what's happening. https://github.com/jenkins-infra/pipeline-library/blob/376e4789fcfca012198fd2dccba7436db87b3a36/vars/buildPlugin.groovy#L310 is forcing the version of the plugin to use Jenkins Core 2.164.1 even though this plugin is using 2.222.1 (https://github.com/jenkinsci/metrics-plugin/blob/master/pom.xml#L68). Checking if there is a INFRA issue to track that.

@alecharp
Copy link
Member

I just created https://issues.jenkins.io/browse/INFRA-2798

@batmat
Copy link
Member Author

batmat commented Nov 10, 2020

What I don't really get is why #58 was green when a PR, but failed when merged.

We want to drive this, or "explode" the recommended configurations here directly to move forward.
There has been multiple attemps to evolve recommendedConfigurations (I personally quite pushed back against some of the attempts), to no avail until now.

First step: only Linux default build, will uncomment the rest
progressively to see what/if this fails.
@batmat batmat force-pushed the check-ci branch 3 times, most recently from 68c0c56 to 1824ec4 Compare November 10, 2020 11:34
@batmat batmat changed the title CI test Fix CI failure Nov 10, 2020
@batmat
Copy link
Member Author

batmat commented Nov 10, 2020

Confirmed, windows build is the only one failing.

This was referenced Nov 10, 2020
@batmat batmat requested a review from alecharp November 10, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore internal improvement with no user facing modification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants