[JENKINS-49262] Apply log filters (e.g. Timestamper, AnsiColor) to module builds #114
Conversation
With the "Build modules in parallel" option selected, each module build would previously create two output streams to the same log file: one in hudson.model.Run.execute and another in the MavenBuild.ProxyImpl2 constructor. Opening that second output stream caused the data written to the log file so far to be discarded. The second output stream is unnecessary for parallel builds and so it is no longer created.
When the "Build modules in parallel" option is selected, the configured build wrappers are now inherited by each of the module builds. Previously the BuildWrapper.setUp method would be called by both the module set builds and the module builds, but the remaining BuildWrapper methods were called during the module set build only. Plugins such as Timestamper, AnsiColor, Build Timeout, etc will now work. This requires the previous commit in order for log filters (such as Timestamper, AnsiColor, etc) to be applied throughout the entire log file.
When the "Build modules in parallel" option is _not_ selected, log filters (such as Timestamper, AnsiColor, etc) are now applied to each module log. They were previously applied to the module set build only.
(to trigger a new build)
|
PR ready for review. @aheritier @jglick @oleg-nenashev |
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
It looks correct. Would be nice to have some unit tests, but it's up to the maintainer. Maybe better to deliver it as is taking the issue importance
|
Seems there are no objections. Could I have this merged please? |
|
@aheritier @jglick @olamy @oleg-nenashev @olivergondza May I have a volunteer to merge the branch? Changes have been approved - thanks Oleg. I've now added test coverage too. Please do let me know if there is anything I can do to make these changes easier to review. |
|
I do not know who, if anyone, maintains this plugin. Generally it should be considered deprecated. |
|
this need some rebase |
|
BTW as of jenkinsci/ansicolor-plugin#132 this should not be needed for coloration. (Not clear it was to begin with—there is special coloration for Maven build metadata anyway.) |
|
This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
5 participants
JENKINS-49262
Apply log filters to each module build, not just the top-level module set build.
Scenarios tested with Timestamper 1.8.9: