Skip to content

Add a dependencyManagement section if missing #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 1 commit into from
Aug 12, 2022
Merged

Add a dependencyManagement section if missing #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/org/jenkinsci/maven/plugins/hpi/TestDependencyMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,12 +579,12 @@ private static void applyOverrides(
throw new MojoExecutionException("Cannot add self to dependency management section");
}
DependencyManagement dm = project.getDependencyManagement();
if (dm != null) {
log.info(String.format("Adding dependency management entry %s:%s", key, dependency.getVersion()));
dm.addDependency(dependency);
} else {
throw new MojoExecutionException(String.format("Failed to add dependency management entry %s:%s because the project does not have a dependency management section", key, overrides.get(key)));
if (dm == null) {
dm = new DependencyManagement();
project.getModel().setDependencyManagement(dm);
}
log.info(String.format("Adding dependency management entry %s:%s", key, dependency.getVersion()));
dm.addDependency(dependency);
overrideAdditions.add(key);
}
} else {
Expand Down