[JENKINS-67974] Java 11 support for MemoryAssert#assertGC #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Mar 31, 2022
src/main/java/org/jenkinsci/maven/plugins/hpi/InitializeMojo.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Ready, tested with Java 17 and my other PRs with Needs a change to the test harness to actually start bundling the hook, and upgrade insane, and get the integration tests to pass. I am preparing that PR next. |
Member
Author
|
jglick
approved these changes
Mar 31, 2022
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Some suggestions but looks good.
| * @author Basil Crow | ||
| */ | ||
| @Mojo(name = "initialize", defaultPhase = LifecyclePhase.INITIALIZE) | ||
| @Mojo(name = "initialize", requiresDependencyResolution = ResolutionScope.TEST, defaultPhase = LifecyclePhase.INITIALIZE) |
Member
There was a problem hiding this comment.
I think it would make more sense to do this in a test preparation phase if we can?
Member
Author
There was a problem hiding this comment.
I agree. I might split this out into a different mojo soonish in some separate PR.
src/main/java/org/jenkinsci/maven/plugins/hpi/InitializeMojo.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of #322. Upstream of jenkinsci/jenkins-test-harness#400. Still in draft state pending the resolution of apache/netbeans#3743. Tested in Java 17 with
mvn clean verify -Dtest=org.jenkinsci.plugins.workflow.libs.LibraryMemoryTest -Djenkins.version=2.341 -Dhpi-plugin.version=3.27-SNAPSHOT.