Making PermissionAdderTest run in PCT

[jglick]

In jenkinsci/bom#359 the test from #23 fails when jth.jenkins-war.path is set to the megawar. Seems that SignupPage.submit quietly returns even when the signup in fact fails. Trying the page interactively showed that it would refuse to proceed unless you entered an email address. Making this change makes the test pass when jth.jenkins-war.path is set. The test utility predates the new signup page GUI but it is not clear that is relevant; I have not figured out what about the megawar (bundled JavaScript?) would change behavior here.

[daniel-beck]

I have not figured out what about the megawar (bundled JavaScript?)

Presence of mailer plugin?

[jglick]

Oh, perhaps.

[jglick]

Hmm, apparently needs to catch ElementNotFoundException in case mailer is absent. On mobile, can try that on Monday.

[jglick]

https://github.com/jenkinsci/jenkins/blob/7aa52381f8d716f19ff71d7cf37970767ed5bbac/core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/_entryForm.jelly#L75 FTR

[daniel-beck]

Now it failed in

matrix-auth-plugin/src/test/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixPropertyTest.java

Line 111 in df6f649

wc = r.createWebClient().login("alice");

, rerunning.

[jglick]

Hmm, passed locally, not sure what that is about.