JENKINS-59110: enable logging globally for pipeline jobs #93

mwinter69 · 2020-04-13T16:34:56Z

To be able to log globally for pipeline a TaskListenerDecorator must be
implemented.
Potentially the decorator will be transferred to the agent jvm so
everything must be Serializable (this is not tested).
This also includes getting information about stage/agent if the logstash step is inside a stage/node

To be able to log globally for pipeline a TaskListenerDecorator must be implemented. Portentially the decorator will be transferred to the agent jvm so everything must be Serializable (this is not tested).

name of stage and/or name of agent are included in the output if the logstash step is inside a stage and/or agent

src/test/java/jenkins/plugins/logstash/persistence/AbstractLogstashIndexerDaoTest.java

src/main/java/jenkins/plugins/logstash/configuration/ElasticSearch.java

src/main/java/jenkins/plugins/logstash/LogstashWriter.java

jakub-bochenski · 2020-04-15T10:54:39Z

src/main/java/jenkins/plugins/logstash/persistence/AbstractLogstashIndexerDao.java

-public abstract class AbstractLogstashIndexerDao implements LogstashIndexerDao {
+public abstract class AbstractLogstashIndexerDao implements LogstashIndexerDao, Serializable {
+
+  private static final long serialVersionUID = 1L;


same thing about serials

jakub-bochenski · 2020-04-15T10:54:44Z

src/main/java/jenkins/plugins/logstash/persistence/BuildData.java

 */
-public class BuildData {
+public class BuildData implements Serializable {
+  private static final long serialVersionUID = 1L;


same thing about serials

jakub-bochenski · 2020-04-15T10:54:56Z

src/main/java/jenkins/plugins/logstash/LogstashWriter.java

-public class LogstashWriter {
+public class LogstashWriter implements Serializable {
+
+  private static final long serialVersionUID = 1L;


same thing about serials

jakub-bochenski · 2020-04-15T10:55:09Z

src/main/java/jenkins/plugins/logstash/persistence/BuildData.java

  private final static Logger LOGGER = Logger.getLogger(MethodHandles.lookup().lookupClass().getCanonicalName());
-  public static class TestData {
+  public static class TestData implements Serializable {
+    private static final long serialVersionUID = 1L;


same thing about serials

jakub-bochenski · 2020-04-15T10:55:37Z

src/main/java/jenkins/plugins/logstash/persistence/ElasticSearchDao.java

 public class ElasticSearchDao extends AbstractLogstashIndexerDao {

-  private final HttpClientBuilder clientBuilder;
+  private static final long serialVersionUID = 1L;


same thing about serials

src/main/java/jenkins/plugins/logstash/persistence/ElasticSearchDao.java

jakub-bochenski · 2020-04-15T11:01:10Z

This also includes getting information about stage/agent if the logstash step is inside a stage/node

Would this cover the functionality from #92?

@tgatinea

remove field and suppress the warning the class definition is transferred along side the object thus the servialversionuid should be the same in any case

jakub-bochenski · 2020-04-17T15:16:57Z

@mwinter69 big thanks for another great contribution :)

gozer2222 · 2020-06-18T14:07:03Z

Hi @jakub-bochenski,

The pipeline is KO, could you take a look, please ?
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Flogstash-plugin/detail/master/65/pipeline

Thx,

jakub-bochenski · 2020-06-18T14:14:12Z

sorry, nothing I can do here, this is Jenkins infrastructure that is not maintaned by me

gozer2222 · 2020-06-30T09:48:22Z

Hi @jakub-bochenski,

Thank you for your answer.

Sorry if I insist a little bit, I can't wait to test and deploy this new great feature 😉

I'm not an expert, but if you push anything on the master branch that should restart the pipeline and the release process.
So a good option could be to validate the PR #94 (very few changes & relevant), which should then publish the new version and make me and the community happy 🥳

What do you think about that?

jakub-bochenski · 2020-06-30T09:52:18Z

Merged, Thanks for bumping it as I missed that PR

Hokwang · 2020-07-08T12:06:13Z

@jakub-bochenski When will you release this PR? I am waiting.

jakub-bochenski · 2020-07-08T13:48:24Z

You can always find the unreleased build in the incremental update center, e.g. current one is https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/logstash/2.4.0-rc195.4527bc400e15/

Hokwang · 2020-07-13T02:11:59Z

@jakub-bochenski Yeah, I know that user can use unofficial release, but I just wonder when you release new version.

jakub-bochenski · 2020-07-17T15:43:02Z

Incremental releases are not "unofficial", they are incremental

Logstash plugin 2.4.0 has been released

admoriarty · 2020-08-03T12:35:39Z

@jakub-bochenski Not sure this is worth logging as a Bug yet, so thought to ask here. Our Jenkins masters and plugins are latest but our jnlp slave image is old so it may be on our side, working through upgrades there now. Anyway, since we picked up 2.4.0 last week we've had some odd symptoms such as console logs for stages looping indefinitely in the master, and then spotted this stack in the slave image logs;

WARNING: null
java.lang.IllegalStateException: Jenkins.instance is missing. Read the documentation of Jenkins.getInstanceOrNull to see what you are doing wrong.
	at jenkins.model.Jenkins.get(Jenkins.java:777)
	at jenkins.model.GlobalConfiguration.all(GlobalConfiguration.java:75)
	at jenkins.plugins.logstash.LogstashConfiguration.getInstance(LogstashConfiguration.java:289)
	at jenkins.plugins.logstash.LogstashWriter.getIndexerDao(LogstashWriter.java:162)
	at jenkins.plugins.logstash.LogstashWriter.getDaoOrNull(LogstashWriter.java:201)
	at jenkins.plugins.logstash.LogstashWriter.<init>(LogstashWriter.java:82)
	at jenkins.plugins.logstash.pipeline.GlobalDecorator.decorate(GlobalDecorator.java:41)
	at org.jenkinsci.plugins.workflow.log.TaskListenerDecorator$DecoratedTaskListener.getLogger(TaskListenerDecorator.java:237)
	at org.jenkinsci.plugins.workflow.log.TaskListenerDecorator$CloseableTaskListener.getLogger(TaskListenerDecorator.java:279)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:740)
	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)
	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)
	at hudson.remoting.UserRequest.perform(UserRequest.java:212)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:369)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)
	at java.lang.Thread.run(Thread.java:748)

If we turn off "Enable Globally" all is well again (except no logstash output of course :D )

jakub-bochenski · 2020-08-06T14:12:49Z

@admoriarty please file this as a separate issue
If it's causing problems for you it's an issue alright. Filling it separately should increase visibility in case other people have the same problem.

On the problem itself I don't think that JNLP version is relevant.
If this code executes on the slave then Jenkins instance won't be available period.

admoriarty · 2020-08-06T16:32:28Z

Will do, have verified since that it wasn't some issue with outdated slave/agent images

…

On Thu, Aug 6, 2020, 16:13 jakub-bochenski ***@***.***> wrote: @admoriarty <https://github.com/admoriarty> please file this as a separate issue If it's causing problems for you it's an issue alright. Filling it separately should increase visibility in case other people have the same problem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCR4OOK2R4GFDMXLTEKZUTR7K27DANCNFSM4MHCHZFA> .

admoriarty · 2020-08-21T14:13:25Z

Eventually raised https://issues.jenkins-ci.org/browse/JENKINS-63472 @jakub-bochenski , felt "critical" made sense since we've basically had to disable the plugin as a result to continue building.

implement TaskListenerDecorator

0d03696

To be able to log globally for pipeline a TaskListenerDecorator must be implemented. Portentially the decorator will be transferred to the agent jvm so everything must be Serializable (this is not tested).

mwinter69 mentioned this pull request Apr 13, 2020

JENKINS-61735 Get all environment variable #92

Open

mwinter69 added 5 commits April 13, 2020 18:49

formatting

f30024b

include stage and agent

eb6e8b2

name of stage and/or name of agent are included in the output if the logstash step is inside a stage and/or agent

test stage and agent

c32179c

thread safety

8b7daa9

fix spotbugs warnings

a5484ba

jakub-bochenski reviewed Apr 15, 2020

View reviewed changes

src/test/java/jenkins/plugins/logstash/persistence/AbstractLogstashIndexerDaoTest.java Outdated Show resolved Hide resolved

jakub-bochenski reviewed Apr 15, 2020

View reviewed changes

src/main/java/jenkins/plugins/logstash/configuration/ElasticSearch.java Show resolved Hide resolved

jakub-bochenski reviewed Apr 15, 2020

View reviewed changes

src/main/java/jenkins/plugins/logstash/LogstashWriter.java Show resolved Hide resolved

jakub-bochenski reviewed Apr 15, 2020

View reviewed changes

src/main/java/jenkins/plugins/logstash/persistence/ElasticSearchDao.java Show resolved Hide resolved

serialversionuid

4a0058a

remove field and suppress the warning the class definition is transferred along side the object thus the servialversionuid should be the same in any case

jakub-bochenski approved these changes Apr 17, 2020

View reviewed changes

jakub-bochenski merged commit 322d92f into jenkinsci:master Apr 17, 2020

Uh oh!

JENKINS-59110: enable logging globally for pipeline jobs #93

JENKINS-59110: enable logging globally for pipeline jobs #93

Uh oh!

Conversation

mwinter69 commented Apr 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakub-bochenski Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

jakub-bochenski Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

jakub-bochenski Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

jakub-bochenski Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

jakub-bochenski Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakub-bochenski commented Apr 15, 2020

Uh oh!

jakub-bochenski commented Apr 17, 2020

Uh oh!

gozer2222 commented Jun 18, 2020

Uh oh!

jakub-bochenski commented Jun 18, 2020

Uh oh!

gozer2222 commented Jun 30, 2020

Uh oh!

jakub-bochenski commented Jun 30, 2020

Uh oh!

Hokwang commented Jul 8, 2020

Uh oh!

jakub-bochenski commented Jul 8, 2020

Uh oh!

Hokwang commented Jul 13, 2020

Uh oh!

jakub-bochenski commented Jul 17, 2020

Uh oh!

admoriarty commented Aug 3, 2020

Uh oh!

jakub-bochenski commented Aug 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

admoriarty commented Aug 6, 2020 via email

Uh oh!

admoriarty commented Aug 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mwinter69 commented Apr 13, 2020 •

edited

Loading

jakub-bochenski commented Aug 6, 2020 •

edited

Loading