add dao to work with logstash tcp #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-bochenski
approved these changes
May 9, 2018
| @Override | ||
| public String getDisplayName() | ||
| { | ||
| return "Logstash"; |
There was a problem hiding this comment.
I think "Logstash TCP" would be clearer
| try { | ||
| createDao(null, 9000); | ||
| } catch (IllegalArgumentException e) { | ||
| assertEquals("Wrong error message was thrown", "host name is required", e.getMessage()); |
There was a problem hiding this comment.
[minor] I think it would be better to use the ExceptionRule here
|
PS. Can you please update the readme? |
use ExpectedException
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a replacement for #29 which has quite some issues