findbugs: fix default encoding issues #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly get displayname of node (jenkinsci#38)
Get the charset of a run and use it whenever we need to convert the String to a byte array
| } | ||
|
|
||
| @Override | ||
| public void setCharset(Charset charset) |
There was a problem hiding this comment.
Can you make it explicit what the purpose here is? We have the charset using during the build, and the charset used to encode the outgoing messages.
Those two do not necessarily need to be the same.
Author
There was a problem hiding this comment.
Added javadoc to describe the purpose
|
For backends that use HTTP transport (Logstash, ES) it would be nice to use the |
Author
|
For this PR I would keep as is. Making mimetype and charset configurable should be done once we have completed the refactoring of configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the charset of a run and use it whenever we need to convert the String to a byte array.