findbugs: fix issues in BuildData #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly get displayname of node (jenkinsci#38)
Use FastDateFormat from apache which is thread safe Avoid possible NPE in Node detection Avoid possible NPE in result (previous logic already avoided it but findbugs still claimed it to be a problem) Node detection is same for pipeline and freestyle so move it to initData method
mwinter69
changed the title
| public class BuildData { | ||
| // ISO 8601 date format | ||
| public transient static final DateFormat DATE_FORMATTER = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ"); | ||
| public transient static final FastDateFormat DATE_FORMATTER = FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ss.SSSZ"); |
There was a problem hiding this comment.
I'm not sure.. the addition of milliseconds can be a breaking change if somebody is parsing the date with a strict parser. I'd suggest extracting the format to configuration if you need the milis part
Author
There was a problem hiding this comment.
ok, I will leave the format as is for now. Making this configurable could be done with the refactoring of configuration
| public class BuildData { | ||
| // ISO 8601 date format | ||
| public transient static final DateFormat DATE_FORMATTER = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ"); | ||
| public transient static final FastDateFormat DATE_FORMATTER = FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ss.SSSZ"); |
There was a problem hiding this comment.
While we'r at it can you restrict it's visibility? The formatter has been made private in #40
Author
There was a problem hiding this comment.
I would like to keep changes in this PR to the findbugs issues. providing a method to access the formatter should be done in a separate PR.
we will make this configurable later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FastDateFormat from apache which is thread safe
Avoid possible NPE in Node detection
Avoid possible NPE in result (previous logic already avoided it but findbugs still claimed it to be a problem)
Node detection is same for pipeline and freestyle so move it to initData method