Parent pom upgrade #17
Conversation
The plugin suports Java 7 only, hence such upgrade is really reasonable
|
Needs a FindBugs cleanup |
|
@oleg-nenashev we are using this plugin on Jenkins instance running Java 8 -- what do you mean by "de-facto the plugin supports Java 7 only"? |
|
@jakub-bochenski Sorry for missing the ping. I meant that Java 6 is not supported, sorry for confusion as well |
|
@oleg-nenashev no problem. I've edited the original message to reflect this. On the topic of this MR: I don't feel that I understand all the consequences of doing this change. |
jakub-bochenski
force-pushed
the
parent-pom-upgrade
branch
3 times, most recently
from
7291f87 to
3488ecc
Compare
@oleg-nenashev ping? |
|
@jakub-bochenski sorry, missed the pings. |
|
in #40 upgrading to 3.2 |
…om-upgrade # Conflicts: # pom.xml # src/main/java/jenkins/plugins/logstash/LogstashBuildWrapper.java
oleg-nenashev
force-pushed
the
parent-pom-upgrade
branch
from
b80e651 to
617cc72
Compare
pom.xml
Outdated
| <parent> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>plugin</artifactId> | ||
| <version>2.15</version> |
There was a problem hiding this comment.
Now it's a downgrade, since pom is at 2.15
There was a problem hiding this comment.
Right, I messed up the merge
pom.xml
Outdated
| </parent> | ||
|
|
||
| <properties> | ||
| <jenkins.version>1.625.3</jenkins.version> |
There was a problem hiding this comment.
Should bump back to 2.7.4
| @SuppressWarnings("deprecation") | ||
| @Initializer(after = InitMilestone.JOB_LOADED) | ||
| public void migrateData() | ||
| public static void migrateData() |
There was a problem hiding this comment.
actually what is the reason for making this method static?
There was a problem hiding this comment.
The initializers are always static. The code won't even compile in newer versions otherwise IIRC
|
Is there any update on this? |
|
Hi @oleg-nenashev and @jakub-bochenski, most parts of this pull request are superseded by pull request #81. |
|
@darxriggs I think what is left is only the initializer conversion to static; any reason you left it out of #81? |
|
I found this pull request afterwards. Mine was really just about pom.xml and cleaned up much more in it. |
4 participants
#17 - [x] Pick latest parent POM with build flow fixes