-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lockable priority strategy #632
Conversation
The feature is more or less complete, I will provide more tests, screenshots and documentation as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that inversePrecedence
now works as #560 (comment) scenario 2.
So that's definitely a step in the right direction.
The new "Queue priority" feature still feels very rough though and will need some polish.
...resources/org/jenkins/plugins/lockableresources/RequiredResourcesProperty/help-priority.html
Outdated
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/RequiredResourcesProperty/config.jelly
Outdated
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/Messages.properties
Outdated
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/LockStep/config.properties
Outdated
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/LockStep/config.jelly
Show resolved
Hide resolved
...ns/plugins/lockableresources/actions/LockableResourcesRootAction/tableQueue/table.properties
Show resolved
Hide resolved
...ns/plugins/lockableresources/actions/LockableResourcesRootAction/tableQueue/table.properties
Outdated
Show resolved
Hide resolved
...jenkins/plugins/lockableresources/actions/LockableResourcesRootAction/tableQueue/table.jelly
Outdated
Show resolved
Hide resolved
@PayBas thx for feadback. I will try to implement it ASAP |
src/main/java/org/jenkins/plugins/lockableresources/LockableResourcesManager.java
Show resolved
Hide resolved
src/main/java/org/jenkins/plugins/lockableresources/actions/LockableResourcesRootAction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good. Didn't find any issues.
Only some minor cosmetic suggestions.
Also note that https://plugins.jenkins.io/data-tables-api/releases/ 2.0 has been released, which breaks quite a bit of the Lockable Resources table.
I had to downgrade the DataTables plugin to v1.13.8-4 in order to properly test/review this PR.
src/main/java/org/jenkins/plugins/lockableresources/LockableResourcesManager.java
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/Messages.properties
Outdated
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/LockStep/help-priority.html
Show resolved
Hide resolved
src/main/resources/org/jenkins/plugins/lockableresources/Messages.properties
Outdated
Show resolved
Hide resolved
...jenkins/plugins/lockableresources/actions/LockableResourcesRootAction/tableQueue/table.jelly
Outdated
Show resolved
Hide resolved
LGTM 👍 |
give me a little bit. I will provide few more automatic tests (for queue management) |
fix #560
fix #223
fix #201
fix #81
Testing done
Inverspe precedence
start time | job | resource | inversePrecedence
------ |--- |--- |---
00:01 | j1 | resource1 | false
00:02 | j2 | resource1 | false
00:03 | j3 | resource1 | true
00:04 | j4 | resource1 | false
00:05 | j5 | resource1 | true
00:06 | j6 | resource1 | false
lock priority
Inverse precendense is not combinable with priority !
Manual tests also done with some priority as string (no-a-number)
Proposed upgrade guidelines
N/A
Localizations
Submitter checklist
@NoExternalUse
. In case it is used by non java code theUsed by {@code <panel>.jelly}
Javadocs are annotated.eval
to ease the future introduction of Content Security Policy (CSP) directives (see documentation).