Clean up the snippet generation for a container template.

[kerogers-cloudbees]

Cleaned up the defaults for Container Template and Container Liveness Probe to minimize the output of a generated snippet for pod templates.

The output with the mandatory fields and the ones we couldn't risk changing:

podTemplate(containers: [containerTemplate(args: 'cat', command: '/bin/sh -c', image: 'dockerImage', name: 'container', workingDir: '/home/jenkins/agent')]) {
    // some block
}

[kerogers-cloudbees]

interestingly, if you put a string that isn't a number into the field, the form validation doesn't happen.

[Vlatombe]

You can use <f:number/> instead of <f:textbox/>

[Vlatombe]

And use FormValidation.validatePositiveInteger(value)

[kerogers-cloudbees]

interesting, FormValidation.validatePositiveInteger() takes a string as the argument. I'd really rather not rework this class to maintain strings and integers for these values.

[Vlatombe]

Ah yes because it works from a textbox, so it expects a string as input.

[Vlatombe]

The validation method can use string but the rest can use int just fine

[Vlatombe]

@kerogers-cloudbees Could you rework the validation methods with @QueryParameter int value ?

[kerogers-cloudbees]

I realize this means all containers will have a liveness probe.

[kerogers-cloudbees]

The image check uses FormValidation.ok() for this, but it really doesn't stand out on the page. Maybe someone from UX can take a quick look and make a judgement on what we should use.

Also this warning appears as soon as you add a container template in the form, it doesn't wait for the text box to gain and lose focus.

[kerogers-cloudbees]

I have it back to producing podTemplate(containers: [containerTemplate(args: 'cat', command: '/bin/sh -c', image: 'bbbbb', name: 'aaaaa', workingDir: '/home/jenkins/agent')]) { // some block } as the output again.