Fix Restart loop on ARM #1124 by adding multi-arch backup pvc multiarch #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce PLATFORMS default (arm64, amd64, s390x, ppc64le) and a docker-buildx target to build and push multi-arch images (IMG=...). The target generates a Dockerfile.cross with platform support, creates and uses a buildx builder, passes UID/GID build args, and cleans up. Mirrors the root Makefile to enable cross-arch image builds. Fixes jenkinsci#1124
Update VERSION.txt and the Helm chart (README, values.yaml) to use quay.io/jenkins-kubernetes-operator/backup-pvc:v0.4.4 so docs and defaults match the new release. bumping the version as part of fixing jenkinsci#1124 based on comment jenkinsci#1124 (comment)
brokenpip3
reviewed
Oct 18, 2025
| .PHONY: docker-buildx | ||
| docker-buildx: check-env ## Build and push multi-arch image (set IMG=quay.io/...:tag) | ||
| @echo "+ $@" | ||
| sed -e '1 s/\(^FROM\)/FROM --platform=\$$\{BUILDPLATFORM\}/; t' -e ' 1,// s//FROM --platform=\$$\{BUILDPLATFORM\}/' Dockerfile > Dockerfile.cross |
There was a problem hiding this comment.
there is no need of doing this, take a look on how we do the whole flow in the root project makefile:
Lines 304 to 364 in bf040e1
also in this file we already have a docker-* commands, let's resume those, ty!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How to publish multi-arch images (same pattern as root)
make -C backup/pvc docker-buildx IMG=quay.io/jenkins-kubernetes-operator/backup-pvc:v0.4.4make -C backup/pvc docker-buildx IMG=quay.io/jenkins-kubernetes-operator/backup-pvc:latestSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.