Skip to content

Fix #753: Remove bogus Java stacktrace highlighting from non-exception output #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anshul-target wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #753: Remove bogus Java stacktrace highlighting from non-exception output #1194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/main/resources/hudson/tasks/junit/CaseResult/test-output.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ THE SOFTWARE.
<l:icon src="symbol-chevron-forward-outline plugin-ionicons-api" />
<l:copyButton text="${value}" iconOnly="true" clazz="jenkins-mobile-hide" />
</summary>

<pre class="jdl-component-code__code">
<code class="language-javastacktrace">
<code class="${codeClass}">
${value}
</code>
</pre>
Expand All @@ -45,12 +44,27 @@ THE SOFTWARE.
</j:if>
</d:tag>
</d:taglib>

<local:item id="${id}" name="error" title="${%Error Details}" value="${it.errorDetails}" />
<local:item id="${id}" name="error" title="${%Error Details}" value="${it.errorDetails}" codeClass="language-javastacktrace" />
<j:forEach var="p" items="${it.properties}">
<local:item id="${id}" name="${p.key}" title="${p.key}" value="${p.value}" />
<local:item id="${id}" name="${p.key}" title="${p.key}" value="${p.value}" codeClass="" />
Copy link
Member

@iamrajiv iamrajiv Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode an empty string instead of removing the parameter entirely? This creates unnecessary complexity.

</j:forEach>
<local:item id="${id}" name="stacktrace" title="${%Stack Trace}" value="${it.errorStackTrace}" />
<local:item id="${id}" name="stdout" title="${%Standard Output}" value="${it.stdout}" />
<local:item id="${id}" name="stderr" title="${%Standard Error}" value="${it.stderr}" />
<local:item id="${id}" name="stacktrace" title="${%Stack Trace}" value="${it.errorStackTrace}" codeClass="language-javastacktrace" />


<j:set var="stdoutClass" value="" />
<j:if test="${it.stdout != null}">
<j:if test="${it.stdout.contains('Exception') or it.stdout.contains('Error') or it.stdout.contains('at ') and (it.stdout.contains('.java:') or it.stdout.contains('Caused by:'))}">
<j:set var="stdoutClass" value="language-javastacktrace" />
</j:if>
</j:if>
<local:item id="${id}" name="stdout" title="${%Standard Output}" value="${it.stdout}" codeClass="${stdoutClass}" />


<j:set var="stderrClass" value="" />
<j:if test="${it.stderr != null}">
<j:if test="${it.stderr.contains('Exception') or it.stderr.contains('Error') or it.stderr.contains('at ') and (it.stderr.contains('.java:') or it.stderr.contains('Caused by:'))}">
<j:set var="stderrClass" value="language-javastacktrace" />
</j:if>
</j:if>
<local:item id="${id}" name="stderr" title="${%Standard Error}" value="${it.stderr}" codeClass="${stderrClass}" />
</j:jelly>